dahlia / sqlalchemy-imageattach

SQLAlchemy extension for attaching images to entities.
https://sqlalchemy-imageattach.readthedocs.io/
MIT License
116 stars 25 forks source link

adding extra keyword arguments to pass to the models constructor #32

Closed pylover closed 8 years ago

dahlia commented 8 years ago

Seems a good idea, but it still doesn’t allow to pass arguments if a constructor takes parameters named size/mimetype/original/etc. I think it would be more flexible if it takes args, kwargs instead of **kwargs.

pylover commented 8 years ago

good idea.

dahlia commented 8 years ago

Could you rebase it on the current master?

pylover commented 8 years ago

here you go

dahlia commented 8 years ago

Too many commits for this. :sweat_smile: Could you rebase them? I think it can be squashed to one commit.

pylover commented 8 years ago

of course. no problem. i like your library

pylover commented 8 years ago

done

dahlia commented 8 years ago

Still too many commits… please rebase them on the current master and squash them into one commit. :disappointed_relieved:

pylover commented 8 years ago

Just rebased

dahlia commented 8 years ago

Even more commits were made. Could you squash all these commits into one single commit? Try utilizing git reset --mixed.