search

daifoundation / maker-otc

The OasisDEX protocol - Simple on-chain market for ERC20 tokens
GNU Affero General Public License v3.0
101 stars 39 forks source link

Non-MAR tokens (WIP) #109

Closed jorisbontje closed 8 years ago

jorisbontje commented 8 years ago

Closes #7

TODO:

rainbreak commented 8 years ago

Do you envisage much more change here? I can rebase #92 on top of it.

jorisbontje commented 8 years ago

I don't expect the market contract to change much anymore. However the UI and wrappers do need to be updated. The tests could be further refactored to remove MAR compatibility; however I haven't done so as to ensure test suite compatibility.

rainbreak commented 8 years ago

Great.

Regarding tests: I think moving away from maker-user is as simple as using Tester from dapple/test and implementing the doApprove method. See how I've done it in token-auction.

So here it's probably just this:

contract MarketTester is Tester {
    function doApprove(address spender, uint value, ERC20 token) {
        token.approve(spender, value);
    }
}
jorisbontje commented 8 years ago

Remove DGD support / flexible precision as it isn't required for the first EIP20 market release

jorisbontje commented 8 years ago

Merged to erc20 branch.