Migrate to dapple 0.8 / solidity 0.4.2

rainbreak commented 8 years ago

Replaces #146.

rainbreak commented 8 years ago

I don't fully understand why initially the pr build fails and the push build passes but I think it's just travis weirdness. The pr build passes when restarted.

rainbreak commented 8 years ago

Looks like travis failure was at least partly due to the dyn ddos.

rainbreak commented 8 years ago

@jorisbontje: so the deployment was successful with all that you've pushed here?

I'm not sure why the tests are failing again.

$ if [ $TEST = "dapple" ]; then dapple test; fi
fs.js:640
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^
Error: ENOENT: no such file or directory, open '/home/travis/build/makerdao/maker-otc/.dapple/.gitignore'
    at Error (native)
    at Object.fs.openSync (fs.js:640:18)
    at Object.fs.writeFileSync (fs.js:1333:33)
    at State.initLocalDb (/home/travis/.nvm/versions/node/v6.8.1/lib/node_modules/dapple/node_modules/dapple-core/state.js:72:10)
    at nextTask (/home/travis/.nvm/versions/node/v6.8.1/lib/node_modules/dapple/node_modules/async/dist/async.js:5208:14)
    at /home/travis/.nvm/versions/node/v6.8.1/lib/node_modules/dapple/node_modules/async/dist/async.js:5202:13
    at apply (/home/travis/.nvm/versions/node/v6.8.1/lib/node_modules/dapple/node_modules/async/dist/async.js:41:25)
    at /home/travis/.nvm/versions/node/v6.8.1/lib/node_modules/dapple/node_modules/async/dist/async.js:76:12
    at /home/travis/.nvm/versions/node/v6.8.1/lib/node_modules/dapple/node_modules/async/dist/async.js:988:16
    at initGlobalState (/home/travis/.nvm/versions/node/v6.8.1/lib/node_modules/dapple/node_modules/dapple-core/state.js:41:7)

jorisbontje commented 8 years ago

@rainbeam dapple issue fixed in https://github.com/nexusdev/dapple-core/commit/df9fb9a09adde4f8cabd16d8f37bf70a4de17b0d ?

rainbreak commented 8 years ago

@jorisbontje: probably. Travis installs dapple from npm so maybe hasn't got that yet.

daifoundation / maker-otc

Migrate to dapple 0.8 / solidity 0.4.2 #147