search

daikon-cqrs / event-sourcing

Immutable CQRS/ES library for Daikon-CQRS projects.
Mozilla Public License 2.0
7 stars 1 forks source link

Sequence vs. SequenceNumber #15

Open graste opened 4 years ago

graste commented 4 years ago

Reading some code in my head I always read Daikon\EventSourcing\EventStore\Stream\Sequence as SequenceNumber - especially in places with $from and $to or $headRev or similar. Dunno what naming is more intuitive without having worked with the codebase, but it seems to be an integerish sequence number for me.

MrHash commented 4 years ago

Thanks for feedback. We have discussed this before and so far came to the conclusion that it's only an internal representation which renders as sequence in the commit. It's not the same as the revision number and not sure if it's used in other ES impls. The revision number is as expected on events. There may be some room for renaming some things so we can keep this open for further consideration.