search

daisy / pipeline

Super-project that aggregates all Pipeline related code, provides a common tracker for Pipeline related issues and holds the Pipeline website
http://daisy.github.io/pipeline
21 stars 21 forks source link

epubcheck notes "ERROR" for rule OPF-093 in generated EPUB3 #702

Open jbrugge opened 1 year ago

jbrugge commented 1 year ago

Expected Behavior

When running the dtbook-to-epub3 script on DAISY books that have pagebreaks in them, the EPUB3 result should have an OPF file that passes epubcheck.

Actual Behavior

Running epubcheck against the generated EPUB3 output produces a report noting an issue with a link item in the OPF. { "ID": "OPF-093", "severity": "ERROR", "message": "The \"media-type\" attribute is required for linked resources located in the EPUB container", "additionalLocations": 0, "locations": [ { "url": { "opaque": false, "hierarchical": true }, "path": "EPUB/package.opf", "line": 2, "column": 3387, "context": null } ], "suggestion": null },

Steps to Reproduce

The sample book in #699 exhibits this issue, so refer to the EPUB3 output from that.

The epubcheck report was then generated with this: epubcheck --json Charlottes_Web-epubcheck.json output-dir/Charlotte_s_Web.epub

Details

Since the zedai-mods.xml are not included in the EPUB3 package, it seems like the element should not be in the OPF at all.

Environment

Logs

epubcheck JSON report

bertfrees commented 10 months ago

I will need the sample book to further investigate this issue.

bertfrees commented 8 months ago

@jbrugge Would it be possible to email me the "Charlotte_s_Web.xml" file please?

bertfrees commented 4 months ago

@jbrugge Could you test this with version >= 1.14.18? When I run EPUBCheck (5.1.0) on the EPUB that you sent me, I don't get the OPF-093 error, but I get another warning:

WARNING(RSC-007w): /Users/bert/Desktop/Charlotte_s_Web.epub/EPUB/package.opf(2,3468): Referenced resource "EPUB/zedai-mods.xml" could not be found in the EPUB.

This is an issue that should have been fixed in 1.14.18 (see https://github.com/daisy/pipeline-modules/commit/efb1b61b38395b33a5d0a942d27a761d8ffd95c4). I didn't get the DTBook from you so I can't check whether there are any other issues.

jbrugge commented 4 months ago

@bertfrees We don't have the 1.14.18 release deployed yet, but I can test again once we upgrade.