dakhnod / Meshenger

open source, P2P messenger without centralized server that works in a local network.
GNU General Public License v3.0
208 stars 45 forks source link

Meshenger crashed when I tried to access About section #22

Open eraydurmus opened 5 years ago

eraydurmus commented 5 years ago

Expected behavior

Users should be able to use the normal functions of the application properly after changing the theme of the Meshenger application and should be able to access to the About/Settings section.

Actual behavior

When I tried to access the about/settings section in Meshenger after taking the theme from light to dark or dark to light, the application stopped working and gave a crash report.

How to reproduce

  1. Open the Meshenger app.
  2. Click on the Dropdown Menu at the top right.
  3. Click on the Settings.
  4. Then activate the Night mode.
  5. Go back and select the About/Settings section by clicking on the Dropdown Menu again.
  6. And you will see that the application crashes immediately.

The following record is only for the "about" section, it also crashes when accessing the "settings" section after changing the theme of the application.

https://im2.ezgif.com/tmp/ezgif-2-0e884436c406.gif

mwarning commented 5 years ago

thanks for the report. I will try to reproduce the problem.

mwarning commented 5 years ago

I tested it and it was working for me. It would be nice to have stack trace or log output to aid finding the problem.

iamvasuh commented 5 years ago

This issue has been fixed now. Checkout the link https://github.com/meshenger-app/meshenger-android

mwarning commented 5 years ago

The fix from @iamvasuh should be included now: https://github.com/meshenger-app/meshenger-android/releases/tag/v2.0.0