[carddav] carddav_show_empty_database_addressbooks=false should not hide LDAP addressbook

[GoogleCodeExporter]

What steps will reproduce the problem?

1.Configure public LDAP addressbook
2.Configure carddav plugin with carddav_show_empty_database_addressbooks=false 
(default)
3.

What is the expected output? What do you see instead?

Configured LDAP addressbook is not shown in Addressbook tab, global search 
doesn't show any results from this book. But autocompletion from LDAP 
addressbook while composing works.
We should be able to use LDAP addressbooks in addressbook tab.

What version of the product are you using? On what operating system?

ubuntu 14.04 amd64
RC 1.1
carddav 8.0.21

Please provide any additional information below.

Another side of the issue: if carddav_show_empty_database_addressbooks is true, 
myrc sets 'Add automatically collected contacts to...' to 'Automatically 
collected (local)'. If there is preinstalled carddav addressbook with 
'is_default=1', I think most people want to use carddav for collected contacts, 
not local AB.
So, I see 3 workarounds in my case:
1. Show LDAP AB in AB tab even if carddav_show_empty_database_addressbooks=false
2. Have an option to set default addressbook for collected contacts.
3. Change algorithm of choosing default collected contacts addressbook.

Original issue reported on code.google.com by urusha.v...@gmail.com on 20 May 2015 at 10:30

[GoogleCodeExporter]

Original comment by myroundc...@gmail.com on 25 May 2015 at 5:33

• Changed title: [carddav] carddav_show_empty_database_addressbooks=false should not hide LDAP addressbook

[GoogleCodeExporter]

We don't use or host an LDAP addressbook. Could you please create a test LDAP 
for us? If so, please send details by our contact form 
(https://myroundcube.com#contact).

Original comment by myroundc...@gmail.com on 25 May 2015 at 6:15

• Changed state: Reproducing

[GoogleCodeExporter]

You could use one of public ldap servers:

$config['ldap_public'] = array (
  'public' =>
   array (
    'name' => 'LDAP',
    'hosts' => array (
      0 => 'ldap.virginia.edu',
    ),
    'port' => 389,
    'use_tls' => false,
    'ldap_version' => 3,
    'user_specific' => false,
    'base_dn' => 'o=University of Virginia,c=US',
    'bind_dn' => '',
    'bind_pass' => '',
    'filter' => '(objectClass=inetOrgPerson)',
    'searchonly' => true,
    'writable' => false,
    'search_fields' => array (
      0 => 'mail',
      1 => 'sn',
      2 => 'givenName',
      3 => 'title',
      4 => 'ou',
    ),
    'fieldmap' => array (
      'name' => 'cn',
      'surname' => 'sn',
      'firstname' => 'givenName',
      'jobtitle' => 'title',
      'email' => 'mail:*',
      'phone:home' => 'homePhone',
      'phone:work' => 'telephoneNumber',
      'phone:mobile' => 'mobile',
      'phone:pager' => 'pager',
      'phone:other' => 'facsimileTelephoneNumber',
      'street' => 'street',
      'zipcode' => 'postalCode',
      'region' => 'st',
      'locality' => 'l',
      'country' => 'c',
      'organization' => 'o',
      'department' => 'ou',
      'notes' => 'description',
    ),
    'scope' => 'sub',
    'fuzzy_search' => true,
    'groups' => array (
      'base_dn' => '',
      'filter' => '(objectClass=groupOfNames)',
      'object_classes' => array (
        0 => 'top',
        1 => 'groupOfNames',
      ),
    ),
  ),
);

Original comment by urusha.v...@gmail.com on 25 May 2015 at 6:47

[GoogleCodeExporter]

Fixed and implemented. There is new configuration value for 
preinstalled_addressbooks 'is_autoabook'.

Original comment by myroundc...@gmail.com on 26 May 2015 at 4:31

• Changed state: Fixed