search

dakrone / es-mode

An Emacs major mode for interacting with Elasticsearch
GNU General Public License v3.0
195 stars 34 forks source link

Symbol’s function definition is void: request #42

Closed greenonion closed 7 years ago

greenonion commented 7 years ago

Hello, thanks for the great work on this package!

When I'm trying to execute a query I'm getting:

es--execute-region: Symbol’s function definition is void: request

on the minibuffer. I guess this is probably this line and related to https://github.com/dakrone/es-mode/pull/41

Running package-list-packages lists the request package as a dependency of es-mode, so I guess I have it installed. This is on OS X by the way. Let me know if I can do anything more to help.

dakrone commented 7 years ago

Whoops sorry! I pushed a commit that should fix it, can you give it a try?

greenonion commented 7 years ago

Yep, it works now! Thanks a lot, I'm a bit embarrassed it was that simple, I should have provided a PR :)

dakrone commented 7 years ago

Thanks for reporting it! :)

greenonion commented 7 years ago

Hey I think you forgot to merge the commit to the master branch :)

ljos commented 7 years ago

Should be OK now.

greenonion commented 7 years ago

Cheers!

dakrone commented 7 years ago

Whoops! Thanks @ljos!