search

dalathegreat / Battery-Emulator

This software enables EV battery packs to be used for stationary storage in combination with solar inverters.
GNU General Public License v3.0
1.1k stars 153 forks source link

BYD-CAN.cpp CAN values are decoded as little endian but should be big endian #612

Closed jsphuebner closed 2 weeks ago

jsphuebner commented 2 weeks ago

https://github.com/dalathegreat/Battery-Emulator/blob/0b966655479860f87d70e3e210dc7240639d7824/Software/src/inverter/BYD-CAN.cpp#L180

Values are decoded as LE but are BE

Those are boring values (just what you sent above) so probably no one ever used them

dalathegreat commented 2 weeks ago

Thanks @jsphuebner , fix is up in PR https://github.com/dalathegreat/Battery-Emulator/pull/613