search

dalehenrich / filetree

Monticello repository for directory-based Monticello packages enabling the use of git, svn, etc. for managing Smalltalk source code.
https://github.com/CampSmalltalk/Cypress
MIT License
133 stars 26 forks source link

Support non-standard selectors with colons #130

Closed timfel closed 10 years ago

timfel commented 10 years ago

Selectors don't have to end with a colon if they take arguments. For example, ContextS changes the selector of layered methods to end with the layer name (e.g. foo: becomes foo: (layerA)). So the translation needs to check if the selector includes colons at all.

timfel commented 10 years ago

And come to think of it, gemstone2.4 might not be the right branch to pull this into. Which branch should I base pull requests on?

timfel commented 10 years ago

@dalehenrich ping?

dalehenrich commented 10 years ago

Thanks for the ping... I've been focussing on Metacello new features and bugfixes...

If you want this patch on the squeak branch, I'll have to cherry pick this to the master branch and then merge master across the board ...

I'll try to remember to get to this one tomorrow ...

timfel commented 10 years ago

Thanks!