search

dalek-cryptography / x25519-dalek

X25519 elliptic curve Diffie-Hellman key exchange in pure-Rust, using curve25519-dalek.
BSD 3-Clause "New" or "Revised" License
326 stars 132 forks source link

Replace unmaintained actions-rs/cargo action in CI workflow #108

Closed striezel closed 1 year ago

striezel commented 1 year ago

Basically all of the actions-rs/* actions are unmaintained. See https://github.com/actions-rs/toolchain/issues/216 for more information. Due to their age they generate several warnings in CI runs, for example in https://github.com/dalek-cryptography/x25519-dalek/actions/runs/4205824089:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

To get rid of those warnings the occurrences of actions-rs/cargo are replaced by direct invocations of cargo.

tarcieri commented 1 year ago

@striezel you'll want to target the release/2.0 branch (which we should really merge into main)

striezel commented 1 year ago

@striezel you'll want to target the release/2.0 branch (which we should really merge into main)

Alright, I've re-applied the changes on top of release/2.0 and switched the base branch to release/2.0.

tarcieri commented 1 year ago

@striezel can you rebase one more time now that #109 is merged?

pinkforest commented 1 year ago

We don't really have any of these anymore as this was superceded by #109 as it was completely replaced workflow

Can be closed - we probably should merge to main after we get the current PRs in tracking here:

striezel commented 1 year ago

@striezel can you rebase one more time now that #109 is merged?

As @pinkforest already said, the current workflows after the merge of #109 do not use actions-rs/cargo anymore, so I will close this.

my_job_here_is_done

:laughing:

Just focus on getting the changes from release/2.0 to main and I'll be happy to see the actions-rs/cargo stuff vanish from the main branch, too.

pinkforest commented 1 year ago

Hey thanks for all your help - we should get it in main soonish partying_face purple_heart

btw if you have some spare cycles, wanna help update https://github.com/rustsec/audit-check ? :heart:

striezel commented 1 year ago

btw if you have some spare cycles, wanna help update https://github.com/rustsec/audit-check ? :heart:

I can try it, but don't get your hopes up, because I've never written a GitHub Action myself.