search

daltoniam / Starscream

Websockets in swift for iOS and OSX
Apache License 2.0
8.36k stars 1.21k forks source link

Add privacy manifest #1008

Closed jonathanellis closed 8 months ago

jonathanellis commented 8 months ago

Issue Link 🔗

A number of people are waiting for this feature here.

Goals âš½

Adds the required privacy manifest to Starscream, along with support for Cocoapods & Swift PM.

Implementation Details 🚧

From what I can tell, Starscream does not use any required reason APIs, nor does it collect any data. I have therefore added an "empty" privacy manifest which confirms this.

I have also added the necessary changes to the podspec (for Cocoapods) and Package.swift (for Swift PM) files. (This also required updated swift-tools-version to 5.3).

NOTE: One of the core maintainers should check that this privacy manifest is correct before merging, as I can take no personal responsibility for making this privacy manifest declaration! (It will also need to be kept up-to-date with any potential future changes to Starscream).

wlxo0401 commented 8 months ago

@acmacalister Please give me your opinion on this PR.

And

I think many people should verify this PR together.

lakshmankreditbee commented 8 months ago

Hi, when can we bring this task to closure.

acmacalister commented 8 months ago

Thanks @jonathanellis. This looks good to me.