search

damienhaynes / moving-pictures

Moving Pictures is a movies plug-in for the MediaPortal media center application. The goal of the plug-in is to create a very focused and refined experience that requires minimal user interaction. The plug-in emphasizes usability and ease of use in managing a movie collection consisting of ripped DVDs, and movies reencoded in common video formats supported by MediaPortal.
12 stars 6 forks source link

GUI refresh after update #750

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Automatic import of inserted DVDs is checked
2. Import couple of DVD's (in my case, i'm talking about DVDs with 6 x XviD
avi on each DVD)
3. Eject any DVD in the drive so it's empty
4. Open MP and Moving Pictures
5. All movies are colored red (not available)
6. Insert new DVD, import is started and new movies are added to the list,
with normal color (available)
7a. Eject DVD, movies are still colored as available until you restart
plugin. Restart plugin, everything is OK, all movies are red again.
7b. Insert old DVD (already scanned, in database), scan is initiated, but
after the scan, as nothing new is added to db, all movies remain red, there
is no GUI refresh.

What is the expected output? What do you see instead?
7a: Catch eject event and refresh GUI.
7b: Refresh GUI after scan

What version of Moving Pictures are you using? What version of MediaPortal?
1.0 Beta 2 with MP Jan 2010 SVN

Original issue reported on code.google.com by mitja.skuver on 1 Feb 2010 at 10:59

GoogleCodeExporter commented 9 years ago 
I got the source and tried to fix this myself as well as couple of other issues 
I've
been having. Included are patch files for the latest trunk, here is a summary of
what's changed:

DBLocalMedia.cs: added GetExistsVolumeSerial(string volumeSerial): returns if 
the
local media with volume serial exists in db.

DeviceManager.cs: update drive state before calling notifiers

MovieImporter.cs: OnVolumeInserted notifier handling public Start/Stop functions

MovingPicturesSettings.cs: added new advanced option "Import DVDs While Not In 
Moving
Pictures Window"

MovingPicturesGUI.cs: 
 * If new advanced option is on, start MovieImporter.OnVolumeInserted notifier on
page load, stop on unload and playback stop.
 * OnVolumeInserted checks if the inserted volume has been added to DB before using
new function in DBLocalMedia (GetExistsVolumeSerial). If it has been, it 
reloads the
facade.
* OnVolumeRemoved reloads the facade
* REMOVED ACTION_HOME handler (in MP there is a key "h" for home, Home key 
should
take you to the top of the facade)

Hope someone will take time to review these changes and apply them in official 
build.

Original comment by mitja.skuver on 9 Feb 2010 at 4:11

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for the patches Mitja. For future reference you can create a single 
patch file 
containing changes to multiple files by generating a patch at the _directory_ 
level. 
If your local changes are still unmodified and you have a few minutes, a single 
patch 
file would save us some time.

Again though thanks for your submissions and we will review them and try to get 
them 
integrated if possible.

Also, please consider jumping on the IRC channel. We are a friendly group of 
people 
and would be very happy to have a new coder pop in from time to time:
http://bit.ly/9gwihs

Original comment by conrad.john on 10 Feb 2010 at 5:47

GoogleCodeExporter commented 9 years ago 
I did some changes and will be uploading single patch later today.

Original comment by mitja.skuver on 10 Feb 2010 at 12:12

GoogleCodeExporter commented 9 years ago 
Here it is:

Original comment by mitja.skuver on 10 Feb 2010 at 7:46

GoogleCodeExporter commented 9 years ago 
:)

Original comment by mitja.skuver on 10 Feb 2010 at 7:46

Attachments:

GoogleCodeExporter commented 9 years ago 
Mitja, just wanted to let you know armandp started reviewing your patch earlier 
today. 
Hopefully he will have time to finalize his review and integrate your changes 
in the 
next day or two. :)

Original comment by conrad.john on 11 Feb 2010 at 2:40

GoogleCodeExporter commented 9 years ago 
After a talk on IRC here is revised patch with some better 
solutions/optimizations.
Hopefully this one will be the one :)

Original comment by mitja.skuver on 11 Feb 2010 at 4:46

Attachments:

GoogleCodeExporter commented 9 years ago 
APondman, I know you took a look at this patch the other day, any update on how 
these 
changes look? And do you think they should go into the trunk or the 1.0 branch? 
I am 
tempted to say lets move this to the trunk (and 1.1) simply because this is not 
a 
critical issue that will cause people a lot of grief.

Original comment by conrad.john on 13 Feb 2010 at 11:46

GoogleCodeExporter commented 9 years ago 
yes this is trunk material :)

Original comment by apond...@gmail.com on 14 Feb 2010 at 12:21

GoogleCodeExporter commented 9 years ago

Original comment by conrad.john on 14 Feb 2010 at 12:23

GoogleCodeExporter commented 9 years ago

Original comment by apond...@gmail.com on 8 Mar 2010 at 10:36

GoogleCodeExporter commented 9 years ago 
removed home action as of r1198

Original comment by apond...@gmail.com on 14 Dec 2010 at 7:35

GoogleCodeExporter commented 9 years ago

Original comment by conrad.john on 31 Jan 2011 at 1:22