danbaterisna / pe

0 stars 0 forks source link

No warning is shown when editing an instance of a recurring task #6

Open danbaterisna opened 2 years ago

danbaterisna commented 2 years ago

Reproduction: With the following save file:

{"tasks": [
    {
        "by_date": " ",
        "identifier": 41005,
        "do_date_start": "5/9/2023 00:00",
        "description": "task2",
        "do_date_end": "5/9/2023 23:00",
        "status": " "
    },
    {
        "by_date": " ",
        "identifier": 41005,
        "do_date_start": "19/9/2023 00:00",
        "description": "task2",
        "do_date_end": "19/9/2023 23:00",
        "status": " "
    },
    {
        "by_date": " ",
        "identifier": 41005,
        "do_date_start": "26/9/2023 00:00",
        "description": "task2",
        "do_date_end": "26/9/2023 23:00",
        "status": " "
    },
    {
        "by_date": " ",
        "identifier": 41005,
        "do_date_start": "3/10/2023 00:00",
        "description": "task2",
        "do_date_end": "3/10/2023 23:00",
        "status": " "
    }
]}

open the application. Then, edit one instance of the recurring task as follows: edit 2 task 2 [SUBMIT PAPER DRAFT]

Then, edit the recurring task as follows: edit 1 task3 /repeat

Expected behavior: Task 2 is unchanged, as per the UG.

Actual behavior: Task 2 is unchanged:

image.png

Note that Sherpass gives no warning message after editing a single instance of a recurring task, which may affect a user who simply forgot to add the /repeat flag.

soc-se-bot commented 2 years ago

Team's Response

This was implemented to adhere to tP constraints of improving testability. As such, we are encouraged to not add extra requests to the users to see if they intend to edit the task for an instance or for multiple occurrences.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I see how a Y/N prompt can complicate matters with the interface. However, I believe a warning printed after the operation should not significantly complicate the design.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: A very low severity is reserved for purely cosmetic issues, and this is an issue that an affect usability.