search

danf747 / geoxml3

Automatically exported from code.google.com/p/geoxml3
0 stars 0 forks source link

failedParse callback not being called #101

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I don't think failedParse is being called

Code is very simple:

                            var p = new geoXML3.parser({

                                map: shared.ms.map,
                                afterParse: self.afterKMLParsed,
                                failedParse: shared.parseFailed
                            });

afterParse runs just fine.
failedParse never gets called.

I am feeding bad KML to the parser, like from this URL:

http://plu.sx/kml/bad.kml

Am I missing something? Is there a reason why failedParse doesn't run? I'm 
currently making my own workaround inside afterParse.

Thanks,
Carlos

Original issue reported on code.google.com by car...@bumpnetworks.com on 8 Oct 2014 at 5:07

GoogleCodeExporter commented 9 years ago 
Before you ask me to make an MCE, please let me know if the bad.kml file should 
even trigger failedParse, by the parser's own design?

If it SHOULD... let me know and I can create an MCE.

Original comment by car...@bumpnetworks.com on 8 Oct 2014 at 5:11

GoogleCodeExporter commented 9 years ago 
Reproduced in both branches.  Looks like the error handling on the XML parser 
failures has changed.

http://www.geocodezip.com/geoxml3_test/v3_geoxml3_kmztest_parseFail_linktoB.html
?filename=http://www.geocodezip.com/geoxml3_test/kml/bad.kml

http://www.geocodezip.com/geoxml3_test/v3_geoxml3_kmztest_parseFail_linktoB.html
?filename=http://www.geocodezip.com/geoxml3_test/kml/bad.kml

Original comment by geocodezip on 10 Oct 2014 at 5:56

GoogleCodeExporter commented 9 years ago 
Cool, glad I helped catch this

Original comment by car...@bumpnetworks.com on 11 Oct 2014 at 4:50

GoogleCodeExporter commented 9 years ago 
fixed polys branch revision #118

Original comment by geocodezip on 23 Dec 2014 at 3:23

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Test page for polys branch:
http://www.geocodezip.com/geoxml3_test/v3_geoxml3_kmltest_parseFail_linktoB.html
?filename=http://www.geocodezip.com/geoxml3_test/kml/bad.kml

Original comment by geocodezip on 23 Dec 2014 at 4:19

GoogleCodeExporter commented 9 years ago 
fixed in kmz branch revision #121

test page for kmz branch:
http://www.geocodezip.com/geoxml3_test/v3_geoxml3_kmztest_parseFail_linktoB.html
?filename=http://www.geocodezip.com/geoxml3_test/kml/bad.kml

Original comment by geocodezip on 23 Dec 2014 at 7:27