search

danger / peril

☢️ Serious and immediate danger.
https://danger.systems
MIT License
461 stars 58 forks source link

relative imports on heroku #460

Closed roopakv closed 4 years ago

roopakv commented 5 years ago

Does anyone know why we dont have relative import support on heroku? Would love to help fix this.

cryptiklemur commented 5 years ago

And whether or not there is a workaround?

orta commented 5 years ago

I'm afraid you'll have to read the code, off the top of my head. I can't think of a reason why it'd be limited to just the multi-user mode

cryptiklemur commented 5 years ago

For some more context: This supposedly should work with this pr, but when using typescript, I'm not able to get them (with import, dynamic import, and require)

cryptiklemur commented 5 years ago

Where exactly is the code that does the github api replacement?

cryptiklemur commented 5 years ago

Does the danger version matter at all? Artsy devs against ^7, but latest is ^9.

runner in the peril codebase also targets ^7: https://github.com/danger/peril/blob/master/runner/package.json#L38

orta commented 5 years ago

That PR indicated that the problem was in how code is evaluated by Danger (in Peril), so I doubt the danger version will affect it.

I think that constraint might have changed since then. You should try removing the check and see if it works without that 👍

cryptiklemur commented 5 years ago

It does not. Kinda out of my depth at this point. The peril stack is pretty big 😄