dani-garcia / vaultwarden

Unofficial Bitwarden compatible server written in Rust, formerly known as bitwarden_rs
GNU Affero General Public License v3.0
39.46k stars 1.91k forks source link

URL in invitation email is the base url of the application #5029

Closed AlexExternalia closed 1 month ago

AlexExternalia commented 1 month ago

Vaultwarden Support String

Your environment (Generated via diagnostics page)

Config (Generated via diagnostics page)

Show Running Config **Environment settings which are overridden:** SIGNUPS_ALLOWED, ADMIN_TOKEN, SMTP_EMBED_IMAGES ```json { "_duo_akey": null, "_enable_duo": false, "_enable_email_2fa": false, "_enable_smtp": true, "_enable_yubico": true, "_icon_service_csp": "", "_icon_service_url": "", "_ip_header_enabled": true, "_max_note_size": 10000, "_smtp_img_src": "cid:", "admin_ratelimit_max_burst": 3, "admin_ratelimit_seconds": 300, "admin_session_lifetime": 20, "admin_token": "***", "allowed_iframe_ancestors": "", "attachments_folder": "data/attachments", "auth_request_purge_schedule": "30 * * * * *", "authenticator_disable_time_drift": false, "data_folder": "data", "database_conn_init": "", "database_max_conns": 10, "database_timeout": 30, "database_url": "***************", "db_connection_retries": 15, "disable_2fa_remember": false, "disable_admin_token": false, "disable_icon_download": false, "domain": "*****://************************", "domain_origin": "*****://************************", "domain_path": "", "domain_set": true, "duo_context_purge_schedule": "30 * * * * *", "duo_host": null, "duo_ikey": null, "duo_skey": null, "duo_use_iframe": false, "email_2fa_auto_fallback": false, "email_2fa_enforce_on_verified_invite": false, "email_attempts_limit": 3, "email_change_allowed": false, "email_expiration_time": 600, "email_token_size": 6, "emergency_access_allowed": true, "emergency_notification_reminder_schedule": "0 3 * * * *", "emergency_request_timeout_schedule": "0 7 * * * *", "enable_db_wal": true, "enable_websocket": true, "event_cleanup_schedule": "0 10 0 * * *", "events_days_retain": null, "experimental_client_feature_flags": "fido2-vault-credentials", "extended_logging": true, "helo_name": "********************", "hibp_api_key": null, "http_request_block_non_global_ips": true, "http_request_block_regex": null, "icon_blacklist_non_global_ips": true, "icon_blacklist_regex": null, "icon_cache_folder": "data/icon_cache", "icon_cache_negttl": 259200, "icon_cache_ttl": 2592000, "icon_download_timeout": 10, "icon_redirect_code": 302, "icon_service": "internal", "incomplete_2fa_schedule": "30 * * * * *", "incomplete_2fa_time_limit": 3, "increase_note_size_limit": false, "invitation_expiration_hours": 120, "invitation_org_name": "Main Solutions", "invitations_allowed": true, "ip_header": "X-Real-IP", "job_poll_interval_ms": 30000, "log_file": null, "log_level": "info", "log_timestamp_format": "%Y-%m-%d %H:%M:%S.%3f", "login_ratelimit_max_burst": 10, "login_ratelimit_seconds": 60, "org_attachment_limit": null, "org_creation_users": "***************************,*****************************", "org_events_enabled": false, "org_groups_enabled": false, "password_hints_allowed": true, "password_iterations": 600000, "push_enabled": false, "push_identity_uri": "https://identity.bitwarden.com", "push_installation_id": "***", "push_installation_key": "***", "push_relay_uri": "https://push.bitwarden.com", "reload_templates": false, "require_device_email": false, "rsa_key_filename": "data/rsa_key", "send_purge_schedule": "0 5 * * * *", "sendmail_command": null, "sends_allowed": false, "sends_folder": "data/sends", "show_password_hint": false, "signups_allowed": false, "signups_domains_whitelist": "", "signups_verify": true, "signups_verify_resend_limit": 2, "signups_verify_resend_time": 3600, "smtp_accept_invalid_certs": false, "smtp_accept_invalid_hostnames": false, "smtp_auth_mechanism": null, "smtp_debug": false, "smtp_embed_images": true, "smtp_explicit_tls": null, "smtp_from": "********************", "smtp_from_name": "Gestorpass", "smtp_host": "******************", "smtp_password": "***", "smtp_port": 587, "smtp_security": "off", "smtp_ssl": null, "smtp_timeout": 15, "smtp_username": "********************", "templates_folder": "data/templates", "tmp_folder": "data/tmp", "trash_auto_delete_days": null, "trash_purge_schedule": "0 5 0 * * *", "use_sendmail": false, "use_syslog": false, "user_attachment_limit": null, "user_send_limit": null, "web_vault_enabled": true, "web_vault_folder": "web-vault/", "yubico_client_id": "103766", "yubico_secret_key": "***", "yubico_server": null } ```

Vaultwarden Build Version

v1.32.0

Deployment method

Official Container Image

Custom deployment method

No response

Reverse Proxy

nginx 1.27.2

Host/Server Operating System

Linux

Operating System Version

Ubuntu 24

Clients

Web Vault

Client Version

No response

Steps To Reproduce

  1. Create templates/email structure at vw-data folder
  2. Add send_org_invite.hbs and send_org_invite.html.hbs from the repository
  3. Restart docker
  4. Send new user invitation through organization admin page

Expected Result

The email should arrive with a button that has a URL with embedded params in it

Actual Result

The email arrives and the button URL is the base url from the vaultwarden installation without any params

Logs

[2024-10-03 07:22:21.266][response][INFO] (get_org_collections_details) GET /api/organizations/<org_id>/collections/details => 200 OK
[2024-10-03 07:22:33.551][request][INFO] POST /api/organizations/239fb8d1-956b-45a7-afe4-2138d3967f2b/users/invite
[2024-10-03 07:22:34.107][response][INFO] (send_invite) POST /api/organizations/<org_id>/users/invite => 200 OK
[2024-10-03 07:22:34.125][request][INFO] GET /api/organizations/239fb8d1-956b-45a7-afe4-2138d3967f2b/users?includeCollections=true
[2024-10-03 07:22:34.126][response][INFO] (get_org_users) GET /api/organizations/<org_id>/users?<data..> => 200 OK
[2024-10-03 07:22:34.126][request][INFO] GET /api/organizations/239fb8d1-956b-45a7-afe4-2138d3967f2b/collections
[2024-10-03 07:22:34.126][response][INFO] (get_org_collections) GET /api/organizations/<org_id>/collections => 200 OK

Screenshots or Videos

No response

Additional Context

No response