keep distinct shouldn't include prev invalid files

danialfarid / ng-file-upload

Lightweight Angular directive to upload files with optional FileAPI shim for cross browser support

MIT License

7.87k stars 1.59k forks source link

keep distinct shouldn't include prev invalid files #2075

Open phazei opened 6 years ago

phazei commented 6 years ago

If there was a timeout or something, a file that had been attempted to be uploaded will fail. If you try to upload that file again when keep distinct is on, then it won't work. That would make sense if the file were already uploaded, but if it hadn't been, then it shouldn't be considered distinct. In the very least ngf-before-model-change should be called so at least the errors could be cleared manually.

dharanid commented 5 years ago

+1 @phazei Did you got that working?