search

daniel-lundin / react-dom-confetti

Trigger confetti explosions on state transitions
624 stars 30 forks source link

className is missing on typescript props type #41

Open piedrahitapablo opened 3 years ago

piedrahitapablo commented 3 years ago

Hi, thanks for your work on this package. I found a bug in the type stubs

Here you can see that the component allows passing className on its props, but that's not reflected on the type stubs. Also, that prop is missing on the repo README.

I can make a PR later this week if that's ok.

daniel-lundin commented 3 years ago

Hi,

Yes, that would be appreciated!

HartiganHM commented 3 years ago

Hey, @daniel-lundin! It looks like there's a fix for this in #35. Any chance it could get reviewed/merged in? Happy to help, if possible!

dannydi12 commented 2 years ago

@daniel-lundin - seems like there no movement on this?