search

daniel-werner / php-quality-tools

Quickly install and set up the necessary quality tools for your php project.
https://www.danielwerner.dev/php-quality-tools-package/
MIT License
42 stars 4 forks source link

#2 Add missing docblock comments #3

Closed krlv closed 5 years ago

krlv commented 5 years ago

Hey @daniel-werner !

Fixes #2 Let me know if I fix all missing docs.

Also, what do you think about @return void? I added them, but I know some people have a really strong opinion against them.

P.S.: interesting & helpful project. Would be really cool to see how it evolve! 👍

daniel-werner commented 5 years ago

Hey @krlv ,

Thanks for the PR, there is only 1 more function in src/helpers.php, with missing docblock. It would be greatly appreciated If you could add it.

daniel-werner commented 5 years ago

p.s. The return void is fine.

krlv commented 5 years ago

@daniel-werner sorry, missed that guessSrcDirectory helper. Fixed!

daniel-werner commented 5 years ago

@krlv Thanks, merging it!