daniel8654 / ziparchive

Automatically exported from code.google.com/p/ziparchive
0 stars 0 forks source link

@property (nonatomic, retain) id delegate??????? #33

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
//
//  ZipArchive.h
//  
//
//  Created by aish on 08-9-11.
//  acsolu@gmail.com
//  Copyright 2008  Inc. All rights reserved.
//
// History: 
//    09-11-2008 version 1.0    release
//    10-18-2009 version 1.1    support password protected zip files
//    10-21-2009 version 1.2    fix date bug

.....................
@interface ZipArchive : NSObject {
.................
@property (nonatomic, retain) id delegate;

...................
@end

You retained delegate???????????? Are you continuing to develop this framework?

Original issue reported on code.google.com by ngtviethung on 11 Jul 2013 at 4:04

GoogleCodeExporter commented 8 years ago
Obviously that should be `weak`, especially in ARC. When incorporating this 
into my project, I fixed that, as well as a lot of other issues. See 
https://github.com/robertmryan/ZipArchive if you're interested.

Original comment by robert.r...@mindspring.com on 21 Oct 2013 at 8:00