danielabar / globi-proto

InfoVis 2015 IVMOOC Globi Explorer
http://danielabar.github.io/globi-proto
MIT License
2 stars 1 forks source link

Livereload isn't working on LESS changes #79

Open danielabar opened 9 years ago

psmacmur commented 9 years ago

Does this have anything to do with using 0.0.0.0 for the server URL instead of localhost?

danielabar commented 9 years ago

Not likely, because then all the livereload stuff would be broken.

The only reason its 0.0.0.0 is used instead of localhost is so the static connect server is accessible from any other machine on the network. That allows you to test on various devices, other computers, screen widths etc, whatever other machines you happen to have lying around.

It's possible that 0.0.0.0 doesn't work on Windows, but this is most likely a separate issue from the livereload.

But for what it's worth, if you happen to have some time, could try switching back to localhost and see if it makes any difference wrt livereload of less changes.

psmacmur commented 9 years ago

Yeah that makes sense. The build is probably hitting an error.

psmacmur commented 9 years ago

I had to npm install grunt-text-replace but then, once I switched the IP to my machine's IP address, livereload worked. Will not work for me with 0.0.0.0 (fail at browser level) or localhost (build fail ENOENT). 127.0.0.1 also works with livereload. This is all on branch 'master'.

danielabar commented 9 years ago

Oh yeah, in general whenever you see incoming changes to package.json, just run npm install and it will just install the new stuff. Same with bower.json and bower install.

So if you use 127.0.0.1, does livereload work with changes to:

psmacmur commented 9 years ago

It was my bad. app/scripts/services/d3extension.js line 17 col 24 Strings must use singlequote. line 18 col 25 Strings must use singlequote. line 126 col 25 Expected '===' and instead saw '=='.

‼ 3 warnings

Warning: Task "jshint:all" failed. Use --force to continue. Fixed in #81