search

danielapai / bioverse

A simulation framework to assess the statistical power of future biosignature surveys
MIT License
7 stars 5 forks source link

Adding new HWO Input Catalog #53

Open nwtuchow opened 4 months ago

nwtuchow commented 4 months ago

I've added the HPIC: The Habitable Worlds Preliminary Input Catalog of Tuchow, Stark, and Mamajek (2024) to the data directory and added a function to read it in functions.py. This branch added the functionality to use a new input catalog and does not affect other areas of Bioverse. I've tested the new function and it appears to work properly.

The file size of the HPIC.txt file has been reduced to only include the relevant properties that Bioverse uses. If there are additional stellar properties from the full HPIC catalog (hosted here) which would be useful for Bioverse please let me know.

nwtuchow commented 3 months ago

If I make these changes to my HPIC_integration branch, will it automatically update it in this pull request, or would I need to make a new request?

matiscke commented 3 months ago

@nwtuchow, if you just push a new commit to your fork nwtuchow:HPIC_integration, the new commit should automatically show up here and become part of this PR.

nwtuchow commented 3 months ago

Yes, I made a change on my end earlier, and I saw that it updated the pull request.

matiscke commented 3 months ago

@nwtuchow Where would be a good place(s) in the documentation to mention the possibility of planet generation with HPIC?

nwtuchow commented 3 months ago

I think it might make sense to discuss it in the "Generating Planetary systems" section of the documentation. I think it would be also be helpful to describe the different options for the generator that are included with bioverse, such as the different functions for planet occurrence rates, generating host stars . The read_HPIC function could be described alongside the other functions