search

danielflower / multi-module-maven-release-plugin

A maven release plugin that is fast, does not add extra commits, and works well with single or multiple modules
http://danielflower.github.io/multi-module-maven-release-plugin/index.html
MIT License
125 stars 65 forks source link

Update plugin dependencies #145

Open msaladin opened 1 month ago

msaladin commented 1 month ago

Hi Daniel,

we are using your release plugin, and it works like a charm. Something which I think is missing is the handling of plugin dependencies. Example:

The service module xxx-sevices has a dependency to the xxx-openapi-spec module, and it has the same dependency in the openapi-generator plugin, so that the plugin has the xxx-openapi-spec in the classpath (and can generate source from the openapi-spec). The generator plugin configuration looks like this:

`

org.openapitools openapi-generator-maven-plugin xxx-group-id xxx-openapi-spec 0.6-SNAPSHOT ` As you can see, there is a SNAPSHOT version in the plugin-dependency, and plugin-dependencies are not automatically updated with your plugin when releasing. So we end up with a SNAPSHOT version in the release, which fails the release build. I checked the source code it would be quite simple to do a PR which would include handling plugin dependencies. What do you think about this feature? I am happy to make a PR. Thanks a lot & Cheers Michael
danielflower commented 4 weeks ago

Hi Michael, yes I think that makes sense. Feel free to make a pull request. Thanks!