search

danielfrg / s3contents

Jupyter Notebooks in S3 - Jupyter Contents Manager implementation
Apache License 2.0
248 stars 88 forks source link

Symbolic links issue with ubuntu and Jupyter Hub #132

Closed arunhallan closed 2 years ago

arunhallan commented 2 years ago

Hi,

I am using s3contents with TLJH (https://tljh.jupyter.org/en/latest/).

The first TLJH hub I set up worked fine.

On the second, the hub can find the s3 folders in the tree view, but can’t load the actual files. Strangely, the first server has symlinks set up for each s3 folder (not sure why), but the first does not.

When I try to load a file, I get the error File Load Error for *.ipynb

I notice 404s when jupyter tries to find a notebook using the Contents Api.

The first is on ubuntu 18 and the second on 20.

Does this sound like an s3contents issue or TLJH?

Thanks

arunhallan commented 2 years ago

The symbolic links were a red herring.

For some reason, the latest version of fsspec exposes isfile() as an async function.

The S3ContentsManager is not awaiting this function, so the function was always returning False.

I downgraded the version of fsspec, but something to look out for.