support ipython 7 - Githubissues

danielfrg / s3contents

Jupyter Notebooks in S3 - Jupyter Contents Manager implementation

Apache License 2.0

248 stars 88 forks source link

support ipython 7 #48

Closed rgbkrk closed 6 years ago

rgbkrk commented 6 years ago

Preliminary testing at least with S3 is working out well.

This did strike me as strange to check based on ipython versions rather than notebook server versions. Anywho, this adapts the work to the latest and greatest.

danielfrg commented 6 years ago

Agreed on the version check using notebook i copied that from pgcontents but i just noticed they updated to use notebook so I will copy their version in another PR.

danielfrg commented 6 years ago

There is something happening on minio inside travis for one specific test.

It's passing locally for me on python3.5

rgbkrk commented 6 years ago

Thanks for adding on commits to get this all set. 😄

coveralls commented 6 years ago

Coverage remained the same at 87.264% when pulling 518e17ea0d36279b2cf7a47d9c1043a55f74f53a on rgbkrk:ipython-7 into 09145f44e2ba93c4e69cccbec1d87860fdb06f79 on danielfrg:master.

danielfrg commented 6 years ago

No problem, thanks for the update.

lauraerinmann commented 5 years ago

Is ipython supported when using the HybridContentsManager to access the local file system as well as s3?

danielfrg commented 5 years ago

Not sure I understand, the HybricContentsManager will work to do what you describe.

lauraerinmann commented 5 years ago

Yup I can see how that could be confusing lol. I meant to ask if the HybridContentsManager will work with ipython 7.