search

danielfrg / s3contents

Jupyter Notebooks in S3 - Jupyter Contents Manager implementation
Apache License 2.0
248 stars 88 forks source link

Adding a way do a custom boto3 instantiation to s3contents (for refreshing AWS keys) #81

Closed milutz closed 4 years ago

milutz commented 4 years ago

The following adds a new c.S3ContentsManager.init_s3_hook configuration option to s3contents so that refreshing credentials can be used. See issue #79 for more background and configuration examples

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.007%) to 88.64% when pulling d099d504ded10a347575b229c19e40c2ea0eb9a1 on milutz:patch-for-passing-botocore into 9ef6f362492f7bad19f3387afb37a6c8913209bc on danielfrg:master.

danielfrg commented 4 years ago

Thanks so much for the PR, is there anything else you want to add?

milutz commented 4 years ago

Let me spend today to try and add docs to the readme and look at the CI stuff to see if there are any easy adds there too, but if its acceptable to you, go ahead and merge tomorrow

milutz commented 4 years ago

@danielfrg I'm not having any luck figuring our how to add to the CI system (I see the tests in s3contents/tests but I'm not sure how to write new ones)

So unless you have other documentation you can point me at for the CI stuff, I'd say go ahead and merge (and certainly feel free to flatten, many of my commits are dumb fixes)

danielfrg commented 4 years ago

Since its and edge case and the regular tests are passing I think this is OK. Thanks for the PR and the help on the other issue!