danielgek / nativescript-sentry

Sentry java/cocoa for nativescript
Apache License 2.0
27 stars 30 forks source link

Doc update & Clearer log for angular error handler #19

Closed bradmartin closed 5 years ago

bradmartin commented 5 years ago
bradmartin commented 5 years ago

@danielgek - The most recent change has been helpful on a project tracking down errors.

This first image shows current iOS result with captureException

bad

You can see here we have the function where this was thrown, but no message indicating what the Error was.

Now with the new error sent to Sentry we get

good

Which you can now see the message of the Error thrown along with the stack. Before we were just taking the stack first and if no stack, using the message but both are valuable information to have.

Also improved the Android handling so we get a message and a "cause" in the Sentry report.

This is not a breaking change, so no need to bump major IMO. I'd bump minor as feature improvement.

danielgek commented 5 years ago

Thanks once again @bradmartin ❤️