Pas Stop Delay value inconsistency between firmware default config and the tool. - Githubissues

danielnilsson9 / bbs-fw

Open source firmware for multiple electric bike motor controllers.

GNU General Public License v3.0

191 stars 39 forks source link

Pas Stop Delay value inconsistency between firmware default config and the tool. #250

Open aalm opened 1 week ago

aalm commented 1 week ago

Noticed a small inconsistency, as BBS-FW Tool does consider 50 as minium; https://github.com/danielnilsson9/bbs-fw/blob/9edfafa09beab245cfdd651bf3aef648c035bb25/src/tool/Model/Configuration.cs#L726

but load_default_config() does set it below that; https://github.com/danielnilsson9/bbs-fw/blob/9edfafa09beab245cfdd651bf3aef648c035bb25/src/firmware/cfgstore.c#L177

I guess 20 is reasonable, as i haven't read anyone having issues with the default config value either(and i've always used it).