Bugfixes / Improvements

danielr18 / connected-next-router

A Redux binding for Next.js Router compatible with Next.js.

MIT License

109 stars 30 forks source link

Bugfixes / Improvements #63

Closed laooola closed 3 years ago

laooola commented 3 years ago

Bugfixes

[x] dispatch LOCATION_CHANGE actions on hash changes (works in v3)

Improvements

[x] add missing return statements in middleware (some middlewares may rely on the return value)
[x] improve e2e tests by adding assertions on the current state of the redux store
[x] change handler for routeChangeError event as the arguments are different (see https://nextjs.org/docs/api-reference/next/router#routerevents)
[x] update example code in README.md

laooola commented 3 years ago

@danielr18 I finally had time to update to v4 - thanks for the time and effort you put into this! Unfortunately I ran into some issues with hash changes not being handled properly. It also broke my middleware chain as one of my middlewares relies on the return value being passed up the chain.

danielr18 commented 3 years ago

@laooola Thanks for making these changes, I've released them in v4.0.1

laooola commented 3 years ago

@laooola Thanks for making these changes, I've released them in v4.0.1

@danielr18 thanks for the quick release! works like a charm 👍