Router Middleware Improvements

danielr18 / connected-next-router

A Redux binding for Next.js Router compatible with Next.js.

MIT License

109 stars 30 forks source link

Router Middleware Improvements #65

Closed laooola closed 1 year ago

laooola commented 3 years ago

Improvements

[x] use store.dispatch to actually dispatch the LOCATION_CHANGE action (so all middlewares are able to process the action; the sequence of applied middlewares does not matter anymore)

laooola commented 3 years ago

@danielr18 here's the improvement I was talking about

kylemh commented 3 years ago

Would this change essentially prevent issues where redirects occur and trigger side-effects through redux-saga using '@@router/LOCATION_CHANGE'?

danielr18 commented 3 years ago

@kylemh I don't think it would make a difference for that, care to explain the issue you are seeing?

kylemh commented 3 years ago

No issue! Basically doing the last bit of our migratory work from when I last commented, and we're finally ditching all of react-router. This PR just made me worried there is an issue.