search

danielroe / nuxt-time

⏰ SSR-safe time element for Nuxt 3
MIT License
349 stars 15 forks source link

fix: handle camel-case options correctly #197

Closed larsjkr closed 9 months ago

larsjkr commented 1 year ago

Resolves https://github.com/danielroe/nuxt-time/issues/196

The Problem was that Intl.DateTimeFormat expects e.g. timeZone, but the current implementation passes e.g. timezone instead.

// currently
new Intl.DateTimeFormat(options.locale, { timezone: 'America/New_York' });

// after fix
new Intl.DateTimeFormat(options.locale, { timeZone: 'America/New_York' });
codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (da15ccd) 100.00% compared to head (d9f6be8) 99.10%. Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #197 +/- ## =========================================== - Coverage 100.00% 99.10% -0.90% =========================================== Files 3 3 Lines 105 112 +7 Branches 9 11 +2 =========================================== + Hits 105 111 +6 - Misses 0 1 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielroe commented 9 months ago

My apologies for the long delay on reviewing this, and thank you for the fix ❤️