danielschuster-muc / potter-db

A Harry Potter database for all your wizarding needs: Books, Characters, Movies, Spells, and Potions. Powered by https://github.com/danielschuster-muc/scrabby

https://potterdb.com

MIT License

98 stars 38 forks source link

Add Potions Pages #780

Closed westerandr closed 1 year ago

westerandr commented 1 year ago

Summary

Added Potion Index and Show Pages
Created Skeleton Animations that fit content
Added Potions link to Footer
Added Potions Type
Added extra prop to Load More Button
Added metadata for SEO
Added re-usable components that make up index and show pages

Related Issues

This closes #764

Checklist

[x] This pull request has a meaningful title and description.
[x] I have read and followed the Contributing guidelines.
[x] My code follows the conventions and coding style of this project.
[x] All tests pass and I have added tests for my changes
[x] I have updated necessary documentation

Screenshots (if applicable)

Additional information

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
potter-db	✅ Ready (Inspect)	Visit Preview	Oct 20, 2023 9:43am

1 Ignored Deployment

westerandr commented 1 year ago

@danielschuster-muc let me know if you have any feedback please.

westerandr commented 1 year ago

Thank you very much sir! If there is nothing else to add, I would like to open up another PR to refactor the new changes to the new-website branch after this one is merged :)

danielschuster-muc commented 1 year ago

Thank you very much sir! If there is nothing else to add, I would like to open up another PR to refactor the new changes to the new-website branch after this one is merged :)

Maybe you could also wait for #765 as this adds Spell Pages before you create a PR for the refactoring.

westerandr commented 1 year ago

Sure will do. Thank you!