danigeos / tisc

TISC is a code to model isostasy, erosion/sediment transport/sedimentation, and tectonic kinematics, mostly for the study of sedimentary basins and source to sink systems.
https://sites.google.com/site/daniggcc/software/tisc
16 stars 2 forks source link

New errors from update #22

Open mberry28 opened 4 years ago

mberry28 commented 4 years ago

Hi there,

I have been making updates to a project that I have worked in the past. I did a few minor output adjustments to the source code, and I started getting the error below. I went back to the old edition (without the updates), recompiled TISC and tried it again the same error persists. These errors seem to only be sources that have complied on recent updates to the Mac OS. I have tested old tisc executables that were complied previously and they work fine without errors.

I have looked at the code that is make this error and it doesn't seem to make sense why it would be happening, since I have run this code before.

I appreciate any suggestions you might have on this.

ERROR: In Define_Drainage_Net: [187][177] -->> [-268433415][1342179321] 'L' ERROR: In Define_Drainage_Net: [188][177] -->> [-268433415][1342179321] 'L' ERROR: In Define_Drainage_Net: [189][177] -->> [-268433415][1342179321] 'L' ERROR: In Define_Drainage_Net: [191][171] -->> [-268435456][805308409] 'L' ERROR: In Define_Drainage_Net: [192][172] -->> [-268435456][805308409] 'L' ERROR: In Define_Drainage_Net: [194][171] -->> [805308409][-268435456] 'L' ERROR: In Define_Drainage_Net: [196][170] -->> [805308409][-268435456] 'L' ERROR: In Calculate_Discharge: [179][185] transferring water to lake in [180][185] is < than outlet [175][174]: 234.5<263.1. ERROR: In Calculate_Discharge: [178][185] transferring water to lake in [178][186] is < than outlet [175][174]: 231.4<263.1. ERROR: In Calculate_Discharge: [180][184] transferring water to lake in [180][185] is < than outlet [175][174]: 227.9<263.1. ERROR: In Calculate_Discharge: [178][179] transferring water to lake in [179][180] is < than outlet [0][199]: 194.8<1294.9.

mberry28 commented 4 years ago

I should also mention that these errors eventually produce a segmentation fault.

danigeos commented 4 years ago

My only suggestion right now is: try removing the call to the write_file_river_basins in tiscio.c. There is a bug in find_up_river i never managed to solve. It could be this. The entire Spain is currently under home self-isolation and it will last for a couple of weeks at least, so it will be difficult to put some time on this.

Other standard measures to try: reduce resolution if it is above 200x200

Remove evaporation to see if it's an issue about closed drainage? That's where most bugs usually are.

Let me know about your project when you can.

On Mon, Mar 16, 2020 at 5:58 AM Michael Berry notifications@github.com wrote:

I should also mention that these errors eventually produce a segmentation fault.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/danigeos/tisc/issues/22#issuecomment-599345228, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYFBCXIUISJCFLMNWSDQO3RHWWVZANCNFSM4LLX3Q6A .