danini / magsac

The MAGSAC algorithm for robust model fitting without using an inlier-outlier threshold
Other
429 stars 65 forks source link

C++ Installation with CREATE_SAMPLE_PROJECT ON #35

Open franciscoQM opened 8 months ago

franciscoQM commented 8 months ago

I am having issues building when CREATE_SAMPLE_PROJECT is set to ON.

/magsac/examples/cpp_example.cpp: In function 'void testEssentialMatrixFitting(double, double, const string&, bool, bool, double)': /magsac/examples/cpp_example.cpp:403:24: error: 'loadMatrix' is not a member of 'gcransac::utils'; did you mean 'loadMatrix'? 403 | if (!gcransac::utils::loadMatrix<double, 3, 3>(source_intrinsics_path, | ^~~~~~~~~~ In file included from /magsac/examples/cpp_example.cpp:16: /magsac/src/pymagsac/include/magsac_utils.h:115:6: note: 'loadMatrix' declared here 115 | void loadMatrix( | ^~~~~~~~~~ /magsac/examples/cpp_example.cpp:403:35: error: expected primary-expression before 'double' 403 | if (!gcransac::utils::loadMatrix<double, 3, 3>(source_intrinsics_path, | ^~~~~~ /magsac/examples/cpp_example.cpp:403:35: error: expected ')' before 'double' 403 | if (!gcransac::utils::loadMatrix<double, 3, 3>(source_intrinsics_path, | ~ ^~~~~~ | ) /magsac/examples/cpp_example.cpp:411:24: error: 'loadMatrix' is not a member of 'gcransac::utils'; did you mean 'loadMatrix'? 411 | if (!gcransac::utils::loadMatrix<double, 3, 3>(destination_intrinsics_path, | ^~~~~~~~~~ In file included from /magsac/examples/cpp_example.cpp:16: /magsac/src/pymagsac/include/magsac_utils.h:115:6: note: 'loadMatrix' declared here 115 | void loadMatrix( | ^~~~~~~~~~ /magsac/examples/cpp_example.cpp:411:35: error: expected primary-expression before 'double' 411 | if (!gcransac::utils::loadMatrix<double, 3, 3>(destination_intrinsics_path, | ^~~~~~ /magsac/examples/cpp_example.cpp:411:35: error: expected ')' before 'double' 411 | if (!gcransac::utils::loadMatrix<double, 3, 3>(destination_intrinsics_path, | ~ ^~~~~~ | ) /magsac/examples/cpp_example.cpp: In function 'void opencvEssentialMatrixFitting(double, double, const string&, bool)': /magsac/examples/cpp_example.cpp:1205:24: error: 'loadMatrix' is not a member of 'gcransac::utils'; did you mean 'loadMatrix'? 1205 | if (!gcransac::utils::loadMatrix<double, 3, 3>(source_intrinsics_path, | ^~~~~~~~~~ In file included from /magsac/examples/cpp_example.cpp:16: /magsac/src/pymagsac/include/magsac_utils.h:115:6: note: 'loadMatrix' declared here 115 | void loadMatrix( | ^~~~~~~~~~ /magsac/examples/cpp_example.cpp:1205:35: error: expected primary-expression before 'double' 1205 | if (!gcransac::utils::loadMatrix<double, 3, 3>(source_intrinsics_path, | ^~~~~~ /magsac/examples/cpp_example.cpp:1205:35: error: expected ')' before 'double' 1205 | if (!gcransac::utils::loadMatrix<double, 3, 3>(source_intrinsics_path, | ~ ^~~~~~ | ) /magsac/examples/cpp_example.cpp:1213:24: error: 'loadMatrix' is not a member of 'gcransac::utils'; did you mean 'loadMatrix'? 1213 | if (!gcransac::utils::loadMatrix<double, 3, 3>(destination_intrinsics_path, | ^~~~~~~~~~ In file included from /magsac/examples/cpp_example.cpp:16: /magsac/src/pymagsac/include/magsac_utils.h:115:6: note: 'loadMatrix' declared here 115 | void loadMatrix( | ^~~~~~~~~~ /magsac/examples/cpp_example.cpp:1213:35: error: expected primary-expression before 'double' 1213 | if (!gcransac::utils::loadMatrix<double, 3, 3>(destination_intrinsics_path, | ^~~~~~ /magsac/examples/cpp_example.cpp:1213:35: error: expected ')' before 'double' 1213 | if (!gcransac::utils::loadMatrix<double, 3, 3>(destination_intrinsics_path, | ~ ^~~~~~ | ) In file included from /magsac/graph-cut-ransac/src/pygcransac/include/estimators/fundamental_estimator.h:49, from /magsac/graph-cut-ransac/src/pygcransac/include/estimators/solver_essential_matrix_five_point_stewenius.h:37, from /magsac/src/pymagsac/src/magsac_python.cpp:3:

franciscoQM commented 8 months ago

The issue can be resolved by adding the line: add_definitions(-DCREATE_SAMPLE_PROJECT) in the CMakeLists.txt