search

dankraus / padawan360

Arduino sketches for R2-D2 remote control with Xbox 360 Controller
BSD 3-Clause "New" or "Revised" License
64 stars 47 forks source link

Fixed foot drive issues, updated baud rate to new standard, clarified variable names, updated dome code to new version of Android #1

Closed rcorvus closed 8 years ago

rcorvus commented 8 years ago

Fixed foot drive issues, updated baud rate to new standard, clarified variable names, updated dome code to new version of Android

rcorvus commented 8 years ago

I hope this helps, thanks again for converting the Padawan to the Xbox360 controller!!!

dankraus commented 8 years ago

@rcorvus - Not sure if it was an accident but you closed this. I'm reopening.

rcorvus commented 8 years ago

Ok thanks

dankraus commented 8 years ago

@rcorvus - I finally had a chance to look over your changes against what I have running.

Can you explain the issues you had with the turnthrottle stuff. I'm not seeing any issues with turning near as I can tell. As to why I had it the way I did, I couldn't telly out. It's been a long time! I'm not having that speed issue you mentioned...

Did change eliminate the need for doing negative turn throttle in? ST.turn(-turnThrottle);

I'm at a con right now with my droid and don't have a USB cable on my to try it out.

Thanks for clearing up the variable names.

dankraus commented 8 years ago

Hey @rcorvus , I incorporated a bunch of your fixes. I had made some variable name tweaks along the way so there a whole bunch of merge conflicts. Incorporated some controller shutoff button combo someone had shown in the thread on Astromech. If this was a project at work, I'd take the time to do this right but....

Most notably, I took your Dome changes and dropped them right in. Your revised credit still remains in there of course. I'm going to leave the baud rates in there as is. I have the baud rate options in the docs and in the code as options.

Thanks for your contributions and sorry I'm only now formally closing this. I had cracked it open a few times over the last few months.

rcorvus commented 8 years ago

Ok cool, thanks for letting me know!