search

danmarsden / moodle-plagiarism_urkund

Ouriginal plagiarism plugin for Moodle (previously called Urkund)
https://ouriginal.com/
12 stars 19 forks source link

bug when editing an activity: form shows always all urkund settings, even those considered advanced #151

Closed jpahullo closed 2 years ago

jpahullo commented 2 years ago

At line:

https://github.com/danmarsden/moodle-plagiarism_urkund/blob/main/lib.php#L1070

there is the comparison: if ($modulename = 'mod_assign' && !is_siteadmin() && which actually makes an assignment, perverting the behaviour then on, and preventing the application of the feature of advanced settings.

The fix is just making a real comparison: if ($modulename == 'mod_assign' && !is_siteadmin() &&.

With this change, the feature of advanced settings is kept.