danmarsden / moodle-plagiarism_urkund

Ouriginal plagiarism plugin for Moodle (previously called Urkund)
https://ouriginal.com/
12 stars 19 forks source link

Finding submissions that do not appear in grading table #93

Closed thepurpleblob closed 7 years ago

thepurpleblob commented 8 years ago

Example...

mysql> select id,identifier,userid, relateduserid, filename,reporturl,statuscode,similarityscore,attempt from mdl_plagiarism_urkund_files where id=164959\G
*************************** 1. row ***************************
             id: 164959
     identifier: 16743b40d984200716b1097b649ae4451fecb5c0
         userid: 33840
  relateduserid: 77496
       filename: 2243726S.docx
      reporturl: https://secure.urkund.com/view/22993875-896146-911636
     statuscode: Analyzed
similarityscore: 8
        attempt: 2
1 row in set (0.00 sec)

However, when you look at the assignment in Moodle...

screen shot 2016-11-17 at 15 04 00

Nothing at all for that user (the user can't see their score either). I appreciate that this is a submitted on behalf of entry which probably has something to do with it.

As this is our live system, it's very difficult (well, impossible) to debug the thing.

danmarsden commented 8 years ago

The first thing I'd check would be to see if the contenthash of the current submission matches the contenthash in the db - If they don't match it would suggest the file was updated and it didn't trigger a new submission to Urkund. If they do match it suggests a bug with the way it grabs the record from the db to show the report.

danmarsden commented 7 years ago

I reproduced this specific issue and found a fix which I've added (where relateduserid <> userid - and the submission was made on-behalf.) - will leave the other issue open as you suggest it occurred in a normal submission as well?