Allow embedding http(s) image sources as base64

[nobels]

Hi there, please provide some info about your enviornment before submiting this issue:

• device :
• OS : Windows
• node version : v12.18.0
• npm version : 6.14.5
• error message : after NPM start -> after changing file auto generation works. Then i get this message

[23:06:58] Starting 'run-pipeline'... [23:06:58] Starting 'dupe'... [23:06:58] Finished 'dupe' after 153 ms [23:06:58] Starting 'less'... [23:06:58] Finished 'less' after 11 ms [23:06:58] Starting 'sass'... [23:06:58] Starting 'dupe'... [23:06:58] Finished 'dupe' after 154 ms [23:06:58] Starting ''... [23:06:58] Finished '' after 9.78 ms [23:06:58] Finished 'sass' after 166 ms [23:06:58] Starting 'postcss'... [23:06:58] Finished 'postcss' after 34 ms [23:06:58] Starting 'lint'... [23:06:58] Finished 'lint' after 15 ms [23:06:58] Starting 'build'... [23:06:58] Finished 'build' after 21 ms [23:06:58] Starting 'check-for-unused'... � 2 unused properties in ns: logoUrl2, logoTwitter [23:06:58] Finished 'check-for-unused' after 79 ms [23:06:58] Finished 'run-pipeline' after 489 ms [23:06:58] Plumber found unhandled error: Error: write callback called multiple times [23:06:58] Plumber found unhandled error: Error: write callback called multiple times

<table class="rbcc footer__main__col4" align="left">
        <td class="footer__main__col4__td" align="left">
          <a href="<!-- @echo linkedin -->"> 
            <img  src="<!-- @echo logoLinkedin -->" alt="Linkedin" class="footer__main__col4__td__img" />
          </a>          
        </td>
</table>

even in my config the value is there:

"linkedin": "https://www.linkedin.com/in/xxxx/",
"logoLinkedin": "/assets/3.png",

If I remove the src -> it works. add it back -> error Changed the source to external image -> error When i add other image -> error When i use existing image link (first image) -> error

So i don't understand why it's not rendering correct.

• Does the order of the conf.json variables mather ? (it should not be)

[danmindru]

Hi @nobels, thanks for the report. At the moment, image embedding only works for local images. Not sure what it would take to support http urls, but I suppose the current implementation build.js#L37 has to change to a custom implementation. That means we'd get rid of the current gulp plugin, gulp-inline-images-no-http

I'll keep this as a feature request, and have a think about it. Feel free to pick it up, if you have any suggestions regarding the implementation :)

[danmindru]

Versions v6.1.0 & up now allow embedding remote (http) images as base64 by adding the inlineRemoteUrl property in config 🎉