search

dantarion / SF5DInput

DirectInput support for Street Fighter 5 PC
MIT License
65 stars 6 forks source link

Improvement request: Beep when using hotkey for switching sides #13

Closed pokeshark closed 8 years ago

pokeshark commented 8 years ago

Hi Dantarion and WydD,

Great project, helps with hosting offlines on PC a lot, even for other games as well like Rocket League. So, thanks!

One small suggestion, if you will: when using the hotkey for switching player sides, can you play a sound to know it registered? The windows beep sound will suffice: System.Media.SystemSounds.Beep.Play();

PS: I would commit the change myself, but I don't have enough SSD space to install Visual Studio and test the change

WydD commented 8 years ago

Glad to know it works right of the bat for other games :) I'll test this at some points to see how it works. thanks for the idea of using systemsounds.

dantarion commented 8 years ago

https://msdn.microsoft.com/en-us/library/ms679277(VS.85).aspx This should work nicely.

WydD commented 8 years ago

Played with it a bit. Beep works but it's aggressive and ignores the application sound level (resulting in a violent beep noise for me :p). I used PlaySound to play a default windows sound (here "Media\Windows Hardware Insert.wav"), available in win7-8-10 and it is considered in the sound channel of SFV.

@pokeshark Let me know if this works for you https://petitl.fr/dl/sf5dinput-snapshot-sound-notify.zip

pokeshark commented 8 years ago

@WydD it works, tested in Windows7 with 3 different controllers (PS360+, DS3, some DS3 knock-off). thanks!