Unable to share screen or record screen

[sheepymeh]

xdg-desktop-portal-wlr is broken for me on this fork. I am testing using the gUM test page. I have tried using the packaged xdg-desktop-portal-wlr and also xdg-desktop-portal-wlr-git.

Logs from xdg-desktop-portal-wlr

``` Found module linux-vdso.so.1 with build-id: 675e36402854b277c88f65a41eb2b6aec1f43295 Found module libpipewire-module-session-manager.so with build-id: c4d7add4d51c17e6ec5d614ebbd0260a596acabc Found module libpipewire-module-metadata.so with build-id: a9751ac0eb1a623fce9a6088d8cca24c1feef4dd Found module libpipewire-module-adapter.so with build-id: 8f5882a722d017cc95b5e5cbad7bca41f5c0424a Found module libpipewire-module-client-device.so with build-id: 32864d4f5ec9c2ee94a040400e1b0a778340e786 Found module libpipewire-module-client-node.so with build-id: a2e33aa0cfa427b5ea501a3bf3d3bdeb8cb90b9f Found module libpipewire-module-protocol-native.so with build-id: 276a805b4237eb5e34335bd94c27e7d1a5dcebb4 Found module libnss_files.so.2 with build-id: 1a36dfc01d3a1010b2ee79766a24a8090a3266d5 Found module libdbus-1.so.3 with build-id: 74f2ab9c60512f3a93c932c3f627564d42e0b11e Found module libspa-dbus.so with build-id: 7f65bdaad708ac9fbdf3166b23bac444ae2b5017 Found module libspa-journal.so with build-id: 38c88d8fc212988f786aa1247b68d6dfab730823 Found module libspa-support.so with build-id: 95ddb02c8e90b0e2b938e201534054a802dd9da0 Found module libgpg-error.so.0 with build-id: ba85170c2d9343ea05eea8fa2048c212ff4ef552 Found module libdl.so.2 with build-id: 5abc547e7b0949f89f3c0e21ab0c8331a7440a8a Found module ld-linux-x86-64.so.2 with build-id: 040cc3dd10461562f177df39e3be2f3704258c3c Found module libgcrypt.so.20 with build-id: db45f5d5e0f7af1e77324fea1885f974619ad268 Found module libcap.so.2 with build-id: 8c4261e5023ecf0e9caa1c9a757c794b885a560b Found module liblz4.so.1 with build-id: e63600ab23b2f6997f42fac2fa56e1f02ce159a1 Found module libzstd.so.1 with build-id: 4b10444c1560ebc574af4d5f488b7408b22d450e Found module liblzma.so.5 with build-id: f8d607153b2b315f1aaa1c8e12553d544e661f2d Found module libpthread.so.0 with build-id: 07c8f95b4f3251d08550217ad8a1f31066229996 Found module libffi.so.7 with build-id: de60e99f39569d11d09160bbdcd486cedc87d2b6 Found module libc.so.6 with build-id: 4b406737057708c0e4c642345a703c47a61c73dc Found module libinih.so.0 with build-id: 787ca695496c8bfb50cf5b5e5b4445e683e54fcf Found module librt.so.1 with build-id: 75484da2d6f1515189eefa076e0a40328834cd16 Found module libpipewire-0.3.so.0 with build-id: 88ce3b6d2dd306f21294d65806d382340b4cee8f Found module libsystemd.so.0 with build-id: f776aaa16b4e2ba7056d01d928e4b2726ffe2b8b Found module libwayland-client.so.0 with build-id: 58038363d7ea1fd5e6532f6e5f90b1a3ce09388a Found module xdg-desktop-portal-wlr with build-id: 90ef248e5386b980920b4ea82303bb2810b6b88d Stack trace of thread 3876: #0 0x00007fd432257d22 raise (libc.so.6 + 0x3cd22) #1 0x00007fd432241862 abort (libc.so.6 + 0x26862) #2 0x00007fd432241747 __assert_fail_base.cold (libc.so.6 + 0x26747) #3 0x00007fd432250616 __assert_fail (libc.so.6 + 0x35616) #4 0x000055cc07ef85dc xdpw_wlr_frame_free (xdg-desktop-portal-wlr + 0x75dc) #5 0x00007fd432213acd n/a (libffi.so.7 + 0x6acd) #6 0x00007fd43221303a n/a (libffi.so.7 + 0x603a) #7 0x00007fd432595fe4 n/a (libwayland-client.so.0 + 0x9fe4) #8 0x00007fd432592563 n/a (libwayland-client.so.0 + 0x6563) #9 0x00007fd432593cac wl_display_dispatch_queue_pending (libwayland-client.so.0 + 0x7cac) #10 0x000055cc07ef59cc main (xdg-desktop-portal-wlr + 0x49cc) #11 0x00007fd432242b25 __libc_start_main (libc.so.6 + 0x27b25) #12 0x000055cc07ef612e _start (xdg-desktop-portal-wlr + 0x512e) Stack trace of thread 3877: #0 0x00007fd43231992e epoll_wait (libc.so.6 + 0xfe92e) #1 0x00007fd431c25a41 n/a (libspa-support.so + 0x11a41) #2 0x00007fd431c1eb24 n/a (libspa-support.so + 0xab24) #3 0x00007fd432438cd0 n/a (libpipewire-0.3.so.0 + 0x41cd0) #4 0x00007fd4321f5259 start_thread (libpthread.so.0 + 0x9259) #5 0x00007fd4323195e3 __clone (libc.so.6 + 0xfe5e3) ```

Logs from pipewire after xdg-desktop-portal-wlr crashes

```v4l2: unknown media type 2 1 7 tried to set output format: Object: size 256, type Spa:Pod:Object:Param:Format (262147), id Spa:Enum:ParamId:Format (4) Prop: key Spa:Pod:Object:Param:Format:mediaType (1), flags 00000000 Choice: type Spa:Enum:Choice:None, flags 00000000 20 4 Id 2 (Spa:Enum:MediaType:video) Prop: key Spa:Pod:Object:Param:Format:mediaSubtype (2), flags 00000000 Choice: type Spa:Enum:Choice:None, flags 00000000 20 4 Id 1 (Spa:Enum:MediaSubtype:raw) Prop: key Spa:Pod:Object:Param:Format:Video:format (131073), flags 00000000 Choice: type Spa:Enum:Choice:None, flags 00000000 20 4 Id 7 (Spa:Enum:VideoFormat:RGBx) Prop: key Spa:Pod:Object:Param:Format:Video:size (131075), flags 00000000 Choice: type Spa:Enum:Choice:None, flags 00000000 32 8 Rectangle 1920x1080 Rectangle 1920x1080 Prop: key Spa:Pod:Object:Param:Format:Video:framerate (131076), flags 00000000 Fraction 0/1 Prop: key Spa:Pod:Object:Param:Format:Video:maxFramerate (131077), flags 00000000 Choice: type Spa:Enum:Choice:None, flags 00000000 40 8 Fraction 60/1 Fraction 1/1 Fraction 60/1 params Spa:Enum:ParamId:EnumFormat: 0:0 Invalid argument (input format (error set output format: -22 (Invalid argument))) Object: size 168, type Spa:Pod:Object:Param:Format (262147), id Spa:Enum:ParamId:EnumFormat (3) Prop: key Spa:Pod:Object:Param:Format:mediaType (1), flags 00000000 Id 2 (Spa:Enum:MediaType:video) Prop: key Spa:Pod:Object:Param:Format:mediaSubtype (2), flags 00000000 Id 1 (Spa:Enum:MediaSubtype:raw) Prop: key Spa:Pod:Object:Param:Format:Video:format (131073), flags 00000000 Choice: type Spa:Enum:Choice:Enum, flags 00000000 36 4 Id 8 (Spa:Enum:VideoFormat:BGRx) Id 7 (Spa:Enum:VideoFormat:RGBx) Id 11 (Spa:Enum:VideoFormat:RGBA) Id 8 (Spa:Enum:VideoFormat:BGRx) Id 12 (Spa:Enum:VideoFormat:BGRA) Prop: key Spa:Pod:Object:Param:Format:Video:size (131075), flags 00000000 Choice: type Spa:Enum:Choice:Range, flags 00000000 40 8 Rectangle 1x1 Rectangle 1x1 Rectangle -1x-1 params Spa:Enum:ParamId:EnumFormat: 1:0 Invalid argument (output format (error set output format: -22 (Invalid argument))) Object: size 128, type Spa:Pod:Object:Param:Format (262147), id Spa:Enum:ParamId:EnumFormat (3) Prop: key Spa:Pod:Object:Param:Format:mediaType (1), flags 00000000 Id 2 (Spa:Enum:MediaType:video) Prop: key Spa:Pod:Object:Param:Format:mediaSubtype (2), flags 00000000 Id 131074 (Spa:Enum:MediaSubtype:mjpg) Prop: key Spa:Pod:Object:Param:Format:Video:size (131075), flags 00000000 Rectangle 1920x1080 Prop: key Spa:Pod:Object:Param:Format:Video:framerate (131076), flags 00000000 Choice: type Spa:Enum:Choice:None, flags 00000000 32 8 Fraction 30/1 Fraction 30/1 Object: size 128, type Spa:Pod:Object:Param:Format (262147), id Spa:Enum:ParamId:EnumFormat (3) Prop: key Spa:Pod:Object:Param:Format:mediaType (1), flags 00000000 Id 2 (Spa:Enum:MediaType:video) Prop: key Spa:Pod:Object:Param:Format:mediaSubtype (2), flags 00000000 Id 131074 (Spa:Enum:MediaSubtype:mjpg) Prop: key Spa:Pod:Object:Param:Format:Video:size (131075), flags 00000000 Rectangle 640x480 Prop: key Spa:Pod:Object:Param:Format:Video:framerate (131076), flags 00000000 Choice: type Spa:Enum:Choice:None, flags 00000000 32 8 Fraction 30/1 Fraction 30/1 ``` _(The last message with `Object: size 128` keeps repeating itself)_

Testing with wf-recorder does not work for me either. Logs:

$ wf-recorder
selected region 0 0 0 0
failed to copy frame

[sheepymeh]

Is this a regression from #16 or did I stumble upon the issue with DMA-BUF being disabled again? Screenshots fail too as expected:

$ grim
failed to copy output HDMI-A-1

If this is the case, is it possible to enable DMA-BUF for this purpose of screenshots and screen recordings?

[danvd]

@sheepymeh Please try with latest changes. Changed default offscreen framebuffer format.

[sheepymeh]

Thanks! Screenshots and screen sharing are both working now.