Perspectives icon continually spinning

[daveschaefer]

Bug report via email:

Sometimes (not always) I see the extension's icon in the toolbar changing to a circling "loading" icon even if I deactivate automatic checking of sites, and even if visiting non-https sites.

Repro steps:

• Set your Perspectives preferences to not check sites unless you give permission
• Open Firefox (with Perspectives installed)
• Navigate to an http site via the address bar
• Note the Perspectives icon turns into a circle, even though I disabled automatic checking of SSL certificates

[daveschaefer]

I haven't been able to reproduce this myself but I may have discovered a fix nonetheless, while looking at the code and fixing #112 . Currently Perspectives sets the icon spinning when it receives any OnLocationChange event from firefox, even for non-https sites. The icon is then set to another status by other events in the browser. We should change the code to only start spinning for https sites (when we know we'll be sending a query). That may fix this bug.

Checking the scheme for https inside all OnLocationChange events may be a good idea anyway - we may be able to send off the queries at that time, if they haven't been sent off already, thus starting queries sooner, getting results sooner, and moving one step towards getting notary results before the actual connection is made.

[daveschaefer]

A patch for this has now been released as part of v4.5! Closing this ticket.

[daveschaefer]

The reporter confirmed that this fix works. Huzzah!