Strip away copyrighted ICC profile

[DavidPrevot]

While checking for copyrighted ICC profiles, under non free license with a command like:

find . -regextype posix-extended -iregex '.*\.(jpg|png)' \
    -exec sh -c 'identify -verbose "$0" \
    | grep -i copyright && echo "$0"' {} \;

The two following files have been spotted, and the ICC profiles have been removed:

exiftool -icc_profile"-<=" plugin/chrome/content/img/{bad,error}.png

The images have been checked identical to their source, and in addition, the files are about 3 kB smaller without these useless binary data.

[daveschaefer]

Hi David, thanks for the heads-up about this. By ICC profiles you mean International Color Consortium, correct?

Can I ask what prompted you to run this check on these image files? Is it just standard/common practise/a hobby to check the details for any listed copyrights and see if the image can be used with them?

I'm not sure if @danwent has any thoughts on these profiles, how they might have gotten there, or other comments, but I'm fine removing these if it doesn't harm the image and removes some copyrighted data. Perhaps we shouldn't have had those there in the first place?

[daveschaefer]

Aha, I dug up some clarifying links from some of your similar tickets

https://lists.debian.org/debian-devel/2014/05/msg00339.html http://www.color.org/faqs.xalter#p14

[DavidPrevot]

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256

Hi Dave,

Le 19/05/2014 00:35, Dave a écrit :

Aha, I dug up some clarifying links from some of your similar tickets

https://lists.debian.org/debian-devel/2014/05/msg00339.html

Yes, that’s the discussion that triggered my investigation into the packages I comaintain within Debian (since most of them are web related, this kind of sRGB profiles are safe to remove, otherwise I would have proposed to replace such profile by a free alternative).

I must admit this sounds like boring copyright-only hunt, thats why I’m proposing as much “ready to merge” pull requests as possible. I’ve met mostly positive feedback so far (only one project is reluctant), that’s why I continue to slowly propose such fixes upstream instead of introducing them only in the Debian packages.

Regards

David

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1

iQEcBAEBCAAGBQJTeZvIAAoJEAWMHPlE9r08Rg4H/2ILWykzclSflUFlmB6tFbnD AjnI/H+lJuBwd+7qT5Ka7bYeAeFscVV0dPYIFr3+ddD4Eh9zOIiC4m9WSqGesvYp 8odoHsbERMxI7fnOC6myYZdz23zcDSQ2ZG4VwdHuIrLgJ+80vkyHs2Ug+F2WiGWz Xr97QryGmY6f0vX49bOJxCgW6Z2WFY2UnuzYZqZ7ekcmXmVWy6qs2UIPVNqDoSxf U60LggyAMe1QtGJ/7Db++6G5NvG2I1A9Kfpj4QfXmIhJ1EmDHUDcXW5P1CrRDbsU 34jfBAHlcO5ctUl0/NJTVgdbAaNcbG3+weONC2hNUKNPtgqWfx76lfcgspR5E8Y= =481C -----END PGP SIGNATURE-----

[daveschaefer]

Not boring at all - thanks for spotting this :)

I'd like to do a bit of research with exiftool myself to see what exactly it does, but I believe this is a good change and should definitely make it in.

[daveschaefer]

Okay, bringing this in as part of the next release. Thanks David!

Interestingly, if I copy the ICC profile from one of the 5K images to one without an ICC profile, using a command line

exiftool -TagsFromFile plugin/chrome/content/img/bad.png -icc_profile plugin/chrome/content/img/default.png

Then the destination image increases in size to 5K. That profile is pretty hefty!

[daveschaefer]

Hi @DavidPrevot would you like a credit in the Perspectives credit list? If so just let me know the name you'd like to be credited under (my email is in my profile if you'd like to discuss it privately).

Thanks for the patch and for clearing this up!

[DavidPrevot]

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256

Hi Dave,

Le 27/05/2014 00:06, Dave a écrit :

Hi @DavidPrevot would you like a credit in the Perspectives credit list?

I’m not sure helping remove a few bytes of binary data is worth credits, but thanks for the offer.

Thanks for the patch and for clearing this up!

You’re welcome, happy to help. I’ll try to help cleaning such data on a larger scale (within Debian) in the near future, our discussions were helpful, thanks.

Regards

David

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1

iQEcBAEBCAAGBQJThH1uAAoJEAWMHPlE9r08uHAH/j0j0vZy2I/kjGgszHsp5hjM BDAdip2SYfxPKhE3x1/dPvs1ADFbHWSeBk4pXvarKG31iPPNiDnv+neaKhvSr0hQ n109gaTUv9uk7GLViVFVlVy9A/6AH48Nxx2YrNsn0PK0/UwczFt8raWPWyJrNXAj MYuRQ4v3JLiSVy3FbTdYoICY3DtaVvwCt3F69T7JIrMhv8dSXlDUOfidkIMVquOT UuaNa+ZffPPmNM3r7THoJNETILgap4O82ABI2+N4FjL0AbxKE950U39FI4ccnyKQ j06VIZCOLKncT6Ox5q8lE+Wan9CwiQhrqSxmgNcAExJu/heiXjf9Zhk3I0rdWHM= =i8HI -----END PGP SIGNATURE-----