search

danwent / Perspectives

Perspectives Firefox Extension
http://perspectives-project.org
66 stars 19 forks source link

Name or remove magic numbers #145

Open ghost opened 10 years ago

ghost commented 10 years ago

There are two magic numbers in notaries.js. Also see https://github.com/lambdor/Perspectives/commit/d437958b9c970ee9ba043552c200a047d637585a#commitcomment-8036576 .

I'm not sure where the async call nor the magic number 25 come from; you'd have to ask @danwent :P But I'd be happy to look at it later.

daveschaefer commented 10 years ago

I don't know why we have the either of these delays. At the very least we could extract to a variable and name them, as you say. Have you done any testing with it changed or removed?