danwent / Perspectives

Perspectives Firefox Extension
http://perspectives-project.org
66 stars 19 forks source link

expose pref for cache duration #30

Closed danwent closed 10 years ago

danwent commented 13 years ago

If the user has perspectives configured to prompt them before contacting notaries, it is annoying to have such a short cache period. Make this a configurable option, and consider increasing the cache time a bit.

daveschaefer commented 12 years ago

I'll tackle this. Want to assign it to me?

danwent commented 12 years ago

I'd gladly assign it, but for some reason github isn't letting me assign it to you user name. It only gives me the option of assigning myself.

I've never used github issues weight assigning issues before.... do you have to be part of the project or something?

dan

On Sun, Jan 8, 2012 at 4:19 PM, Dave reply@reply.github.com wrote:

I'll tackle this. Want to assign it to me?


Reply to this email directly or view it on GitHub: https://github.com/danwent/Perspectives/issues/30#issuecomment-3405911

Dan Wendlandt
650-906-2650
daveschaefer commented 12 years ago

After some tinkering... if you click on the Admin button at the top of the page, do you get a 'Collaborators' link on the left side? Once I added you as a Collaborator I was able to assign issues to you. Stack Overflow suggests that making someone a Collaborator gives them read and write access to the repo, however, so if you're not comfortable with that, no worries!

None of this seems very well documented. I'll have to look into that.

danwent commented 12 years ago

ok, done. sorry, have gotten behind due to work again.

On Tue, Jan 17, 2012 at 8:49 PM, Dave reply@reply.github.com wrote:

After some tinkering... if you click on the Admin button at the top of the page, do you get a 'Collaborators' link on the left side? Once I added you as a Collaborator I was able to assign issues to you. Stack Overflow suggests that making someone a Collaborator gives them read and write access to the repo, however, so if you're not comfortable with that, no worries!

None of this seems very well documented. I'll have to look into that.


Reply to this email directly or view it on GitHub: https://github.com/danwent/Perspectives/issues/30#issuecomment-3540963

Dan Wendlandt
650-906-2650
daveschaefer commented 12 years ago

No worries! Thanks, I assigned this and a few other issues to myself.

ghost commented 10 years ago

There already is a "perspectives.max_cache_age_sec" preference. Should this also be added to the preference dialog? I recently added the "query timeout" and "query retries" options to the preference and I think it's already getting crowded with rather advanced options. => Close?

daveschaefer commented 10 years ago

Hey, yes, it's the "perspectives.max_cache_age_sec" preference that we should expose in the UI. We should migrate it to the preferred "extensions.perspectives.max_cache_age_sec" location at the same time (I asked on the mailing list and this migration should be fine, as the pref has never been exposed and nobody seems to adjust it manually).

I started work on this in a branch but won't have time to finish it for a few weeks.

getting crowded with rather advanced options

Yes, we will have to be careful about this. We should use well chosen default values to cut down on the tinkering that needs to be done. We can create a third preferences tab to group related items if things are getting too crowded.

ghost commented 10 years ago

We could add a "show advanced option" checkbox or even simpler: a simple note hinting "for more advanced options use about:config -> extensions.perspectives". Then again, it would be the only advanced option for now.

daveschaefer commented 10 years ago

This is now done in version 4.6! :)