search

danwent / Perspectives

Perspectives Firefox Extension
http://perspectives-project.org
66 stars 19 forks source link

Move preference variables to "extensions." #59

Closed daveschaefer closed 8 years ago

daveschaefer commented 12 years ago

Right now the preference variables are stored under "perspectives.". We should move them to "extensions.perspectives.", as detailed here: https://developer.mozilla.org/en/Extensions/Extension_etiquette

This will require an upgrade function to migrate prefs for anyone updating Perspectives.

ghost commented 10 years ago

For anyone implementing this. There is already some update code in notaries.js prompt_update(). A quick fix would be to lookup any preference that starts with "perspectives.", copy them to "extensions.perspectives." and then remove the prior preference.

daveschaefer commented 9 years ago

I have received the AMO review results for Perspectives version 4.6. This issue was identified as something we need to fix before they will bless v4.6 will full approval. It looks like until we fix that v4.6 may not be displayed on the AMO site - https://addons.mozilla.org/en-US/developers/docs/policies/reviews#selection . So fixing this is now a much higher priority.

"Extensions should not alter preferences outside of the 'extensions.' preference branch. Please make sure that all of your extension's preferences are prefixed with 'extensions.add-on-name.', where 'add-on-name' is a distinct string unique to and indicative of your add-on."

netsafe commented 9 years ago

Fixed

daveschaefer commented 8 years ago

Hey, I'm back. Okay, working to test this and send to AMO now.

It looks really good. There is one bug I'm checking to see if it's an actual issue with upgrading (unrelated to your code) or a bug that happens all of the time. It looks like the latter. If so I will push the patch and get this rolling.

Thanks again!

daveschaefer commented 8 years ago

Okay, I've solved the bug :) There was an issue where sometimes the root_prefs object would be null and cause an error during the upgrade. It is now fixed.

Finishing testing and I hope to release this within 1 week.

daveschaefer commented 8 years ago

Okay! PR #173 takes care of fixing the preference location! I cherrypicked and merged netsafe's other two commits and published it.

The changes have been uploaded to AMO and we are now waiting for review. Once they give us approval we should be back to normal publishing updates!