search

danwent / Perspectives

Perspectives Firefox Extension
http://perspectives-project.org
66 stars 19 forks source link

key_weakly_seen_by_quorum() should use the quorum size #89

Closed daveschaefer closed 10 years ago

daveschaefer commented 11 years ago

In client_policy.js we have the function key_weakly_seen_by_quorum(). It takes four parameters: (test_key, results, quorum_size, check_length). But it never uses the quorum_size.

The comments say it's checking that "test_key has been seen by at least 'quorum_size' notaries in the past 'check_length' days". And we loop on the results and check their end dates. But we have a single variable named 'seen' to track if the key has been seen by any notary. Do we want to keep a count of the notaries that have seen and return true if (count_of_sightings >= quorum_size)?

daveschaefer commented 10 years ago

This has been implemented in the version 4.5 release!