Closed m-birke closed 7 months ago
Thanks for this contribution, @m-birke. Looks like this will simplify using DaphneLib a lot! I will look into it in detail later this week.
Hi @m-birke, sorry for the delay... This contribution looks very good to me. I've just polished a few little things (see the commit I added), such as:
test.sh
and run-python.sh
)tmpdaphne.daphne
is also stored in /tmp/DaphneLib/
, not in the pwd (good to prevent cluttering with these files, now that DaphneLib can be run from any directory)I think it would be great to add the installation and little test use of DaphneLib to our GitHub actions to always test if it still works as described in the docs. I would recommend a package installation from the already cloned source then, since installing from the GitHub repo seems to clone the LLVM submodule, which is quite huge.
Hi @pdamme
thanks for the review and the additional fixes. Especially saving "tmpdaphne.daphne" to the new tmp dir as well is important
takeaway for me: add github workflow for actually building and testing the package (or general python related ci/cd), i will create an issue for this
KR
Building the Python DaphneLib as a package Now independent from CWD of python3 cmd execution when running a DLIB script Build artifact producable which can be distributed (potentially can be separated into different git repo now very easily)
I had to touch 90 files for this PR which is a lot, let me point reviewers here to the important changes:
Main issue solved in source code: removal of hardcoded paths
There are more improvements possible but for this PR it is enough