search

daphne-eu / daphne

DAPHNE: An Open and Extensible System Infrastructure for Integrated Data Analysis Pipelines
Apache License 2.0
67 stars 62 forks source link

#650 fix get topology #651

Closed GuilloteauQ closed 10 months ago

GuilloteauQ commented 10 months ago

The get_topology function is returning weird values since the usage of hwloc #563.

https://github.com/daphne-eu/daphne/blob/ccba9387a9b33e5c6b46df0aa3477d3bbab0fbfd/src/runtime/local/vectorized/MTWrapper.h#L87-L96

Namely, the function was just constructing vectors of the correct sizes, but not actually setting the information.

This PR uses hwloc to return the same information as before #563 and fix #650

philipportner commented 10 months ago

Hi @GuilloteauQ , great catch on the missing call to destroy, your fix for #650 and the topology walk look good to me. Thank you for the contribution.