daphtdazz / WebBLE

iOS WebBluetooth Polyfill
Other
113 stars 39 forks source link

getCharacteristics & getPrimaryServices #32

Closed boehlerlukas closed 3 years ago

boehlerlukas commented 4 years ago

We implemented the getCharacteristics and getPrimaryServices BLE methods. I'm looking forward on your feedback.

Fixes #7 and fixes #20

Sponsored by Zemtu (https://www.zemtu.com/)

daphtdazz commented 4 years ago

Hi @boehlerlukas , thanks for submitting them and sorry for not spotting them earlier, I will try and get these merged or back to you if I have any questions asap.

boehlerlukas commented 4 years ago

Hey @daphtdazz ! Awesome, that would be phantastic!

daphtdazz commented 4 years ago

I've started having a look at this, but have run out of time today. Hopefully I will get some more time later this week...

oclyke commented 3 years ago

just tested this PR (though not extensively) and it worked like a charm. thank you SO MUCH @boehlerlukas I can't describe how much time this has saved me!

previously I had been running into 'Not Implemented' on the getCharacteristics method, and I was unable to change the web side code.

boehlerlukas commented 3 years ago

@oclyke great to hear that it helps :) All credits go to @googol7 at Zemtu (https://www.zemtu.com/)

daphtdazz commented 3 years ago

@boehlerlukas sorry I've been rubbish getting round to this. I've merged it, but might make a few tweaks (am going to try and sort out the DEVELOPMENT_TEAM thing so it doesn't change whenever anyone makes a new PR for example) before I release a new version of Webble. I also want to get some tests going!

daphtdazz commented 3 years ago

And also thank you very much for this PR!